refactor(suite-native): transaction review - #32408
Conversation
9c7b5f0 to
477947b
Compare
⚡️ Performance report (alpha)Note Alpha release: The limits are still being calibrated, and each measurement is desktop / group 1⚪️ Following e2e flows within limits:Each metric reads
desktop / group 6⚪️ Following e2e flows within limits:Each metric reads
desktop / group 2⚪️ Following e2e flows within limits:Each metric reads
desktop / group 3⚪️ Following e2e flows within limits:Each metric reads
desktop / group 5⚪️ Following e2e flows within limits:Each metric reads
desktop / group 7⚪️ Following e2e flows within limits:Each metric reads
desktop / group 4⚪️ Following e2e flows within limits:Each metric reads
|
82a7e7f to
46a8469
Compare
|
✅ Previously successful run of [Test] suite-native Android E2E workflow has been found. |
b53b3a4 to
e3b221a
Compare
ddb38d8 to
32040be
Compare
a8eddfa to
395e19f
Compare
395e19f to
ce35eb0
Compare
Description
This PR unifies transaction review screens across all flows (send, trading, staking, yield). It introduces the following changes:
@suite-native/transaction-reviewpackage holding the shared stateTransactionReviewScreenrendered in all transaction review screensuseTransactionReviewcontext controlling the package internallyThe
@suite-native/transaction-reviewcontains the shared review outputs and their rendering, but flows that need special review outputs and their custom handling, such as Yield, Staking, and Trading can extend the default values. Therefore, these flows provide extensions implemented in these hooks:useStakingTransactionReviewOutputs.tsxuseYieldTransactionReviewOutputs.tsxuseTradingTransactionReviewOutputs.tszMost important changed files and packages:
@suite-native/transaction-review- contains all tx review codesuite-native/transaction-review/src/screens/TransactionReviewScreen.tsx- rendered in the tx review flowssuite-native/module-earn/src/hooks/staking/useStakingTransactionReviewOutputs.tsx- extends staking tx review by staking-specific outputssuite-native/module-earn/src/hooks/yield/useYieldTransactionReviewOutputs.tsx- extends yield tx review by yield-specific outputssuite-native/module-trading/src/hooks/useTradingTransactionReviewOutputs.tsx- extends trading tx review by trading-specific outputs<TransactionReviewScreen />Related Issue
Resolve #31630
🤖 LLM Test Recommendations
Summary: All changed files live under suite-native (mobile) or a shared wallet-types type file that is consumed by suite-native transaction-review/send flows. None of the available suite/e2e (web/desktop Suite) tests exercise the suite-native mobile app or its transaction-review components, so there is no relevant E2E coverage in this candidate set. The appropriate verification should happen in the suite-native/mobile E2E test suite rather than suite-web/e2e.
Changed files (28)
suite-common/wallet-types/src/index.tssuite-common/wallet-types/src/transactionReview.tssuite-native/module-send/package.jsonsuite-native/module-send/src/screens/SendOutputsReviewScreen.tsxsuite-native/module-send/tsconfig.jsonsuite-native/transaction-management/src/selectors.tssuite-native/transaction-review/package.jsonsuite-native/transaction-review/src/components/TransactionReviewFooter.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputCard.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputHexData.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputItem.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputItemBadge.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputItemContent.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputItemLabel.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputItemValues.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputSummaryItem.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputsList.tsxsuite-native/transaction-review/src/components/TxValidityTimer.tsxsuite-native/transaction-review/src/hooks/useActiveStepOffset.tsxsuite-native/transaction-review/src/hooks/useHandleCommonSignRejection.tsxsuite-native/transaction-review/src/hooks/useShowDeviceDisconnectedAlert.tsxsuite-native/transaction-review/src/hooks/useTransactionReview.tsxsuite-native/transaction-review/src/hooks/useTransactionReviewBackInterceptor.tsxsuite-native/transaction-review/src/hooks/useTransactionReviewCancellationAlert.tsxsuite-native/transaction-review/src/hooks/useTxValidityFlow.tsxsuite-native/transaction-review/src/index.tssuite-native/transaction-review/src/screens/TransactionReviewScreen.tsxsuite-native/transaction-review/tsconfig.jsonNo test recommendations found.
suite-common/wallet-types/src/index.tssuite-common/wallet-types/src/transactionReview.tssuite-native/module-send/package.jsonsuite-native/module-send/src/screens/SendOutputsReviewScreen.tsxsuite-native/module-send/tsconfig.jsonsuite-native/transaction-management/src/selectors.tssuite-native/transaction-review/package.jsonsuite-native/transaction-review/src/components/TransactionReviewFooter.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputCard.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputHexData.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputItem.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputItemBadge.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputItemContent.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputItemLabel.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputItemValues.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputSummaryItem.tsxsuite-native/transaction-review/src/components/TransactionReviewOutputsList.tsxsuite-native/transaction-review/src/components/TxValidityTimer.tsxsuite-native/transaction-review/src/hooks/useActiveStepOffset.tsxsuite-native/transaction-review/src/hooks/useHandleCommonSignRejection.tsxsuite-native/transaction-review/src/hooks/useShowDeviceDisconnectedAlert.tsxsuite-native/transaction-review/src/hooks/useTransactionReview.tsxsuite-native/transaction-review/src/hooks/useTransactionReviewBackInterceptor.tsxsuite-native/transaction-review/src/hooks/useTransactionReviewCancellationAlert.tsxsuite-native/transaction-review/src/hooks/useTxValidityFlow.tsxsuite-native/transaction-review/src/index.tssuite-native/transaction-review/src/screens/TransactionReviewScreen.tsxsuite-native/transaction-review/tsconfig.jsonUpdated: 2026-09-14T07:26:25.443Z
🌐 Preview deployments
🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/refactor/native/transaction-review/web/
🔍 Currents Test Results
🔍 Suite desktop test results: View in Currents
🔍 Suite web test results: View in Currents
🔍 Suite native android test results: View in Currents
🔒 Quarantined E2E Tests
Trezor Suite (web) — 1 test(s)
Updated: 2026-09-25T12:27:37.518Z • 1 test(s) total
Trezor Suite (desktop) — 1 test(s)
Updated: 2026-09-25T12:27:13.488Z • 1 test(s) total