Introduced toggle for app focusing behavior when device is unlocked#26829
Open
tomasz90 wants to merge 2 commits intotrezor:developfrom
Open
Introduced toggle for app focusing behavior when device is unlocked#26829tomasz90 wants to merge 2 commits intotrezor:developfrom
tomasz90 wants to merge 2 commits intotrezor:developfrom
Conversation
tomasz90
force-pushed
the
app-focus-toggle
branch
from
23a6a24 to
092a034
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi, I reported such issue(not PR) previously but it wasn't well received. After some time, I realised that my description and explanation wasn't very good.
So... probably Trezor team assumes that the main interface that user interacts and initiate transactions is Trezor Suite, so it is indeed reasonable to bring Trezor Suite into front when user unlocks their device.
But this is not the case for all of users, for instance I use mainly third parties wallets like Rabby, Metamask or Jupiter for Solana. For me when I unlock my device before initiating a tx (because I give my device time to bluetooth sync), I see Trezor Suite popup which often covers extension wallet interface, so I need to minimise Trezor Suite then initiate or accept a tx in extension and finally THIS EXTENSION is responsible of bringing Trezor Suite window to the front. This becomes a little mess.
So in my opinion there should be an option to disable default behavior - for users who don't use Trezor Suite to send/swap/do defi inside Trezor Suite, because they use other apps and Trezor Suite is only needed for bringing confirmation screen. This option can be enabled by default - but still user can turn this behavior off.
Related Issue
Resolve #23847
Screenshots: