Open
Conversation
…rder widths and state colors with Figma, drop activeColor prop Aligns the Radio atom with the new design system spec: - remove the filled background (radio is now transparent in every state) - use a uniform 2px border in all states (previously 1.5px when unchecked) - fix disabled state colors: use borderOnElevationNegative for unchecked disabled border, and backgroundPrimarySubtleOnElevation0 for checked disabled border + inner dot (previously iconSubdued / backgroundNeutralDisabled) - drop the activeColor prop; Figma only defines one active tint (backgroundPrimaryDefault), so the prop is no longer needed Closes #25010
PeKne
force-pushed
the
feat/native/ds-radio
branch
from
6076fa8 to
89fb199
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
activeColorprop; the only caller (FeeOption) already surfaces fee errors viaFeeOptionErrorMessage.Notes for QA
Related Issue
Resolve #25010
🔍 Currents Test Results
🔍 Suite native android test results: View in Currents