test(block/gs): run pre-signed URL test with fake-gcs-server#9987
Closed
skshetry wants to merge 1 commit intotreeverse:masterfrom
Closed
test(block/gs): run pre-signed URL test with fake-gcs-server#9987skshetry wants to merge 1 commit intotreeverse:masterfrom
skshetry wants to merge 1 commit intotreeverse:masterfrom
Conversation
Add `nowFactory` injection and explicit signing credentials to enable proper testing of GetPreSignedURL with `fake-gcs-server`. This follows the same pattern used in the Azure adapter. - Add WithNowFactory option to mock time.Now() for deterministic tests - Add WithPresignedCredentials option for fake-gcs-server signing - Remove "no credentials found" test skip workaround - Include test RSA private key for URL signing
github-actions
bot
added
area/testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
nowFactoryinjection and explicit signing credentials to enable proper testing of GetPreSignedURL withfake-gcs-server. This follows the same pattern used in the Azure adapter.Related: