Skip to content

Comments

Add more golangci linters#9925

Closed
nopcoder wants to merge 5 commits intomasterfrom
task/more-linters
Closed

Add more golangci linters#9925
nopcoder wants to merge 5 commits intomasterfrom
task/more-linters

Conversation

@nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Dec 29, 2025

Update golangci configuration to enable additional linters for improved code quality:

Added Linters:

  • errname: Checks that error names follow Go conventions
  • perfsprint: Checks for performance issues in Printf calls
  • testifylint: Linting for testify assertions
  • revive: Configurable linting with rules for:
    • increment-decrement: Enforces use of ++ and -- instead of += 1 and -= 1
    • indent-error-flow: Enforces proper indentation by removing unnecessary else blocks after return statements
    • use-any: Enforces use of any instead of interface{}
    • use-errors-new: Enforces use of errors.New() instead of fmt.Errorf() for static errors
    • use-waitgroup-go: Enforces proper WaitGroup usage

Configuration Changes:

  • Removed gofmt.simplify setting (now handled by formatters section)

Code Fixes:

  • Fixed 12 revive linting issues across the codebase:
    • 6 increment-decrement issues: Replaced += 1 with ++
    • 6 indent-error-flow issues: Removed unnecessary else blocks for cleaner code flow

@github-actions github-actions bot added area/cataloger Improvements or additions to the cataloger area/gateway Changes to the gateway area/testing Improvements or additions to tests area/lakectl Issues related to lakeFS' command line interface (lakectl) area/block-adapter area/hooks improvements or additions to the hooks subsystem area/KV Improvements to the KV store implementation labels Dec 29, 2025
@github-actions github-actions bot added the area/auth IAM, authorization, authentication, audit, AAA, and integrations with all those label Dec 30, 2025
@nopcoder nopcoder self-assigned this Dec 30, 2025
@nopcoder nopcoder closed this Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth IAM, authorization, authentication, audit, AAA, and integrations with all those area/block-adapter area/cataloger Improvements or additions to the cataloger area/gateway Changes to the gateway area/hooks improvements or additions to the hooks subsystem area/KV Improvements to the KV store implementation area/lakectl Issues related to lakeFS' command line interface (lakectl) area/testing Improvements or additions to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant