Cast decimals to ruby BigDecimals #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is particularly a problem since [0.198](https://prestodb.io/docs/current/release/release-0.198.html), where decimal literals are now interpreted as `DECIMAL` by default, which means a query like `SELECT 1.0` was coming through as a String.
Lewuathe
reviewed
Jan 27, 2020
Contributor
Lewuathe
left a comment
Lewuathe
left a comment
There was a problem hiding this comment.
Hmm, good catch. But the latest presto returns decimal type as String in JSON encoding.
It would be better to keep the returned type as much as possible to avoid unnecessary consufion.
If users want to use decimal as numeric type, they can do that by checking type information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly a problem since 0.198, where decimal literals are now interpreted as
DECIMALby default, which means a query likeSELECT 1.0was coming through as a String.