Fix deprecated testthat::with_mock() warnings#24
Merged
Conversation
added 4 commits
August 9, 2025 20:57
- Use platform-appropriate temporary paths (C:/tmp for Windows, /tmp for Linux) - Extract fake embulk setup to common function to avoid file locking issues - Use recursive directory creation for better cross-platform compatibility - Ensure proper cleanup in each test case
- Resolve R CMD check NOTE about non-standard top-level file - Ensure clean package build for CRAN submission
- Add Author field to DESCRIPTION for compatibility - Remove LazyData field (no data directory exists) - Extend .Rbuildignore to exclude hidden files and check directories - Now passes R CMD check with Status: OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates from deprecated testthat::with_mock() to the mockery package to resolve deprecation warnings.
Closes #22, #23