feat: add "year built" to vehicle labels#279
Open
nathan-weinberg wants to merge 1 commit intotransitmatters:mainfrom
Open
feat: add "year built" to vehicle labels#279nathan-weinberg wants to merge 1 commit intotransitmatters:mainfrom
nathan-weinberg wants to merge 1 commit intotransitmatters:mainfrom
Conversation
"year built" is determined by fetching the lowest-numbered carriage in a set and finding what year it was built Signed-off-by: Nathan Weinberg <nathansweinberg@gmail.com>
nathan-weinberg
requested review from
a team,
idreyn and
mathcolo
as code owners
github-actions
bot
added
frontend
nathan-weinberg
commented
Feb 8, 2026
Comment on lines
+175
to
+176
| holiday_train_cars = os.environ.get("HOLIDAY_TRAIN_CARS", "").split(",") | ||
| pride_train_cars = os.environ.get("PRIDE_TRAIN_CARS", "").split(",") |
Member
Author
There was a problem hiding this comment.
Pre-commit seems to have done this, cc @rudiejd
devinmatte
reviewed
Feb 9, 2026
Comment on lines
+30
to
+31
| "1400-1551": "2018-25", | ||
| "1500-1651": "1969-70", |
Member
There was a problem hiding this comment.
Does this work? There's some overlap here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #276
Changes
Adds new "Oldest car built in " to vehicle labels, based on
Works for Red, Orange, Green, Blue, and Mattapan
Testing Instructions
Run locally, unfortunately I can't get a screenshot