[added] Arrows will have special collision effect with filled bucket#2446
Open
mugg91 wants to merge 1 commit intotranshumandesign:masterfrom
Open
[added] Arrows will have special collision effect with filled bucket#2446mugg91 wants to merge 1 commit intotranshumandesign:masterfrom
mugg91 wants to merge 1 commit intotranshumandesign:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds logic to
Arrow.asindoesCollideWithBlob()in case an Arrow is about to collide with a filled bucket.If so, it checks some conditions.
The conditions:
normalorfireIf the conditions are met, it makes a splash, extinguishes fire arrow and ignores the collision with the bucket (no damage from enemy arrow).
Tested in offline Sandbox, should work the same in online.
ArrowBucketSplash.mp4
Fixes #2445
I removed the
doesCollideWithBlob()call fromonCollision()because otherwise the code indoesCollideWithBlob()runs twice. I have not found issues after removing it.Change Requests
Let me know what you think and if there are requests for changes.
For example, I can make it so enemy arrows will still hit the bucket to deal damage.
Steps to Test or Reproduce
Be archer and shoot at a filled bucket (from your team or enemy team).
Notice it will splash if arrow collides from above.