fix: Duration including background task execution time - #353
Open
yourboirusty wants to merge 8 commits into
Open
fix: Duration including background task execution time#353yourboirusty wants to merge 8 commits into
yourboirusty wants to merge 8 commits into
Conversation
yourboirusty
force-pushed
the
fix-duration-including-background-tasks
branch
from
January 14, 2026 13:23
0012908 to
a103310
Compare
|
@trallnag any plans to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
finallyafter full app execution.Why do we need it?
pre-committo pass. Took the liberty of refactoring a bit more than absolutely necessary.Who is this for?
People who use relatively long-running background tasks but still want accurate response times for every endpoint.
Linked issues
Fixes #275
Reviewer notes
If the refactors are too heavy-handed I can tune it back, but it made sense to me to flatten out the low-hanging fruit while I was at it.
This does not cover two potential issues:
requests without response body will still count background tasks into their duration.I thought it wouldn't cover responses without body, but tests disagree with me.