Skip to content

feat: Add HTTP Basic auth on the metrics endpoint - #289

Draft
zidokobik wants to merge 2 commits into
trallnag:masterfrom
zidokobik:master
Draft

feat: Add HTTP Basic auth on the metrics endpoint#289
zidokobik wants to merge 2 commits into
trallnag:masterfrom
zidokobik:master

Conversation

@zidokobik

Copy link
Copy Markdown

Referencing #283.

@gaby

gaby commented Mar 5, 2024

Copy link
Copy Markdown

@trallnag Can you take a look at this, it fixes a security issue

@codecov

codecov Bot commented Mar 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (b645ccb) to head (224b34a).
Report is 9 commits behind head on master.

❗ Current head 224b34a differs from pull request most recent head ad7b996. Consider uploading reports for the commit ad7b996 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   95.68%   95.79%   +0.10%     
==========================================
  Files           5        5              
  Lines         348      357       +9     
==========================================
+ Hits          333      342       +9     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trallnag
trallnag marked this pull request as draft March 12, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants