refactor: Move from CubeOption to Option#4543
Merged
laggui merged 11 commits intotracel-ai:mainfrom Feb 27, 2026
Merged
Conversation
Contributor
Author
|
Pretty sure that mac CI error is unrelated to this PR, likely related to one of the attention-related commits added since the last cubek update |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4543 +/- ##
==========================================
+ Coverage 61.12% 61.20% +0.07%
==========================================
Files 1086 1086
Lines 140411 140406 -5
==========================================
+ Hits 85831 85936 +105
+ Misses 54580 54470 -110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
laggui
approved these changes
Feb 27, 2026
Member
laggui
left a comment
There was a problem hiding this comment.
Yeah I think tracel-ai/cubek@b857e33 broke the test.
Should not be a blocker for this PR, changes LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
cargo run-checkscommand has been executed.Related Issues/PRs
Requires
tracel-ai/cubecl#1194
tracel-ai/cubek#95
Changes
Migrates to refactor that removes
CubeOptionin favor ofOption, and uses some of the new methods to clean up the code.Testing
All tests pass.