Skip to content

refactor: Move from CubeOption to Option#4543

Merged
laggui merged 11 commits intotracel-ai:mainfrom
wingertge:refactor/cube-option
Feb 27, 2026
Merged

refactor: Move from CubeOption to Option#4543
laggui merged 11 commits intotracel-ai:mainfrom
wingertge:refactor/cube-option

Conversation

@wingertge
Copy link
Copy Markdown
Contributor

Pull Request Template

Checklist

  • Confirmed that cargo run-checks command has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Requires
tracel-ai/cubecl#1194
tracel-ai/cubek#95

Changes

Migrates to refactor that removes CubeOption in favor of Option, and uses some of the new methods to clean up the code.

Testing

All tests pass.

@wingertge wingertge requested a review from laggui February 26, 2026 22:42
@wingertge
Copy link
Copy Markdown
Contributor Author

Pretty sure that mac CI error is unrelated to this PR, likely related to one of the attention-related commits added since the last cubek update

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 0% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.20%. Comparing base (a50709b) to head (46d5793).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...cubecl-fusion/src/optim/reduce_broadcasted/unit.rs 0.00% 19 Missing ⚠️
...-cubecl/src/kernel/conv/deform_conv_transpose2d.rs 0.00% 14 Missing ⚠️
crates/burn-cubecl-fusion/src/optim/matmul/args.rs 0.00% 9 Missing ⚠️
...rates/burn-cubecl/src/kernel/conv/deform_conv2d.rs 0.00% 8 Missing ⚠️
...urn-cubecl-fusion/src/optim/matmul/optimization.rs 0.00% 7 Missing ⚠️
...-cubecl/src/kernel/conv/conv_transpose2d/col2im.rs 0.00% 3 Missing ⚠️
...c/kernel/conv/conv_transpose2d/transpose_direct.rs 0.00% 3 Missing ⚠️
...es/burn-cubecl/src/kernel/conv/conv_transpose3d.rs 0.00% 3 Missing ⚠️
crates/burn-cubecl/src/kernel/conv/direct.rs 0.00% 3 Missing ⚠️
...becl-fusion/src/optim/reduce_broadcasted/launch.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4543      +/-   ##
==========================================
+ Coverage   61.12%   61.20%   +0.07%     
==========================================
  Files        1086     1086              
  Lines      140411   140406       -5     
==========================================
+ Hits        85831    85936     +105     
+ Misses      54580    54470     -110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think tracel-ai/cubek@b857e33 broke the test.

Should not be a blocker for this PR, changes LGTM.

@laggui laggui merged commit 3887fd1 into tracel-ai:main Feb 27, 2026
10 of 11 checks passed
@wingertge wingertge deleted the refactor/cube-option branch February 27, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants