Select previous address value instead of coordinates value#1694
Open
AussieTraccar wants to merge 2 commits intotraccar:masterfrom
Open
Select previous address value instead of coordinates value#1694AussieTraccar wants to merge 2 commits intotraccar:masterfrom
AussieTraccar wants to merge 2 commits intotraccar:masterfrom
Conversation
Member
|
How about we just keep label in web and export coordinates? |
AussieTraccar
commented
Mar 4, 2026
Author
AussieTraccar
left a comment
AussieTraccar
left a comment
There was a problem hiding this comment.
This should be more inline with your requirements?
tananaev
reviewed
Mar 4, 2026
| if (addressEnabled) { | ||
| return ( | ||
| <Link href="#" onClick={showAddress}> | ||
| {coordinates} |
Member
There was a problem hiding this comment.
Do we still use coordinates somewhere?
Author
There was a problem hiding this comment.
Isn't this a catch-all for rare cases that the geocoder is either disabled geocoder.enable = false or unavailable, it returns coordinates by default so that there won't be an empty value for address?
Member
There was a problem hiding this comment.
Then we should probably move below if (addressEnabled), right? There's no need to do formatting if we know we won't use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose: The embedded address link throughout the Traccar UI was updated in commit #bb3756e to display location coordinates instead of 'Show Address' text. Some users may find the coordinates information confusing, preferring the original wording instead.
Solution: This PR adds a server-wide or per user configuration attribute to override the default address link behavior, for backwards compatibility and improved user experience.