fix: apply testenv overrides to TOML env templates#3886
Closed
gaborbernat wants to merge 2 commits intotox-dev:mainfrom
Closed
fix: apply testenv overrides to TOML env templates#3886gaborbernat wants to merge 2 commits intotox-dev:mainfrom
gaborbernat wants to merge 2 commits intotox-dev:mainfrom
Conversation
When using TOX_OVERRIDE with testenv prefix (e.g., `testenv.pass_env+=VAR`), overrides were not applied to TOML configurations because TOML uses different section names (env_run_base, tool.tox.env) than INI (testenv). The loader only looked up overrides by exact section key match. Now check for "testenv" namespace in override_map and apply those overrides to TOML env templates (env_run_base) and env-prefixed sections. This allows users to use the same override syntax across both INI and TOML config formats. Fixes tox-dev#3860
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3860
Summary
TOX_OVERRIDEwith testenv prefix (e.g.,testenv.pass_env+=VAR), overrides were not applied to TOML configurationsenv_run_base,tool.tox.env) than INI (testenv)Changes
toml_pyproject.pyto maptestenvoverrides to TOML env sectionsini.pyto also check section prefix for overridesTest Plan
test_tox_override_pass_env_custom_varto verify custom variables work with TOX_OVERRIDE