feat(windows): add SDIO driver step - #1338
Closed
niStee wants to merge 9 commits into
Closed
Conversation
niStee
marked this pull request as ready for review
September 26, 2025 20:22
Contributor
Author
|
@GideonBear, please take a look. |
Member
|
Hi, sorry for the wait. |
niStee
force-pushed
the
split/windows-sdio-core
branch
from
October 3, 2025 23:37
838f24e to
67b1d45
Compare
# Conflicts: # locales/app.yml # src/config.rs
…tallation process Improves SDIO driver selection and installation control Updates SDIO script commands to enhance the driver update process. Adds `newer` to the `select` command, ensuring that the tool prioritizes newer drivers in addition to missing or better ones. Explicitly controls installation enabling via `enableinstall off` during analysis and `enableinstall on` during actual installation. This prevents unintended installations during dry-runs or analysis and ensures proper execution during the installation phase.
niStee
marked this pull request as draft
October 11, 2025 12:25
barkleesanders
added a commit
to barkleesanders/topgrade
that referenced
this pull request
Mar 8, 2026
Implements Snappy Driver Installer Origin (SDIO) support for Windows. SDIO is opt-in and disabled by default due to its invasive nature (driver updates can brick hardware). Includes vulnerability assessment. From PRs topgrade-rs#1338 and topgrade-rs#1339 by niStee. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
print_infoenable_sdio/sdio_pathconfig knobs, document them inconfig.example.toml, and ensure the example config keeps risky defaults disabledwindows/mod.rs), and wireStep::Sdiointo the runner/default Windows step list (including a clearer "Update WSL" label)Standards checklist
CONTRIBUTING.mdFor new steps
--dry-runoption works with this step--yesoption works with this step if it is supported by the underlying commandTesting