Refactor div buttons to semantic accessible buttons#91
Refactor div buttons to semantic accessible buttons#91tonymendonca23 wants to merge 1 commit intomainfrom
Conversation
- Replace `div` wrappers containing `h4` tags with semantic `<button type="button">` elements. - Update `style.css` to add `font-weight: 700` and `font-family: inherit` to `.btn` and `.sign-up-btn` classes, ensuring visual consistency with the previous design. - Add `:focus-visible` styles (`outline`) for both buttons to ensure keyboard accessibility. - Update `.Jules/palette.md` with learnings on refactoring div-buttons. Co-authored-by: tonymendonca23 <178732622+tonymendonca23@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎨 Palette: Refactor div buttons to accessible button elements
💡 What: Replaced the non-semantic
div > h4button pattern with standard<button>elements for "Join Us" and "Sign up" calls to action.🎯 Why: The original implementation was inaccessible to keyboard users and screen readers (not focusable, no button role).
♿ Accessibility:
outline) for keyboard navigation.📸 Visuals: Visual regression testing confirmed that adding
font-weight: 700maintained the original look (size 18px, bold) provided by theh4tag.PR created automatically by Jules for task 14877398508267066349 started by @tonymendonca23