Skip to content

Refactor buttons to semantic HTML for accessibility#84

Open
tonymendonca23 wants to merge 1 commit intomainfrom
palette-ux-buttons-2470182584490622225
Open

Refactor buttons to semantic HTML for accessibility#84
tonymendonca23 wants to merge 1 commit intomainfrom
palette-ux-buttons-2470182584490622225

Conversation

@tonymendonca23
Copy link
Owner

🎨 Palette: Improved accessibility of buttons

💡 What:

  • Converted "Join Us" and "Sign up" buttons from <div> wrappers to semantic <button> elements.
  • Removed inner <h4> tags and placed text directly in buttons.
  • Updated CSS to reset button styles (font, border, background) to match original design.
  • Added :focus-visible styles for keyboard navigation.
  • Fixed invalid flex-direction: space-between in .call-content to justify-content: space-between.

🎯 Why:

  • Previous div buttons were inaccessible to keyboard users and screen readers.
  • Focus states improve navigation for power users and those with disabilities.
  • Layout bug fix ensures proper spacing in the call-to-action section.

📸 Before/After:

  • Visually identical (verified via screenshots), but now accessible.

♿ Accessibility:

  • Added semantic roles (button).
  • Added keyboard focus support.
  • Improved contrast for focus indicators.

PR created automatically by Jules for task 2470182584490622225 started by @tonymendonca23

Co-authored-by: tonymendonca23 <178732622+tonymendonca23@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant