Skip to content

🎨 Palette: Fix button semantics and layout bug#102

Open
tonymendonca23 wants to merge 1 commit intomainfrom
palette-fix-buttons-layout-2088962325373582914
Open

🎨 Palette: Fix button semantics and layout bug#102
tonymendonca23 wants to merge 1 commit intomainfrom
palette-fix-buttons-layout-2088962325373582914

Conversation

@tonymendonca23
Copy link
Owner

🎨 Palette: Improved Button Semantics and Fixed Layout Bug

💡 What:

  • Converted "Join Us" and "Sign up" buttons from <div> to <button>.
  • Added visible focus indicators for keyboard users.
  • Fixed a broken layout in the Call to Action section (invalid CSS property).

🎯 Why:

  • Accessibility: div buttons are inaccessible to screen readers and keyboard users. Semantic <button> elements provide built-in accessibility features.
  • Usability: Keyboard users can now tab to and activate these primary actions.
  • Visual Polish: The "Call to Action" section was broken due to a CSS typo, causing elements to bunch up. It is now properly spaced.

Accessibility:

  • Added semantic <button> tags.
  • Added :focus-visible styles with high contrast outlines.
  • Ensured button text remains legible and styled consistent with the design.

PR created automatically by Jules for task 2088962325373582914 started by @tonymendonca23

Replaced non-semantic `div` buttons with `<button type="button">` elements for "Join Us" and "Sign up" actions to improve accessibility and keyboard navigation.

Updated `style.css` to:
- Add `:focus-visible` styles with a high-contrast outline for better keyboard accessibility.
- Explicitly set `font-weight: bold` and `font-family: inherit` on button classes to maintain visual consistency after removing inner `h4` tags.
- Fix invalid `flex-direction: space-between` to `justify-content: space-between` in `.call-content`, correcting the Call to Action section layout.

Co-authored-by: tonymendonca23 <178732622+tonymendonca23@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant