Add setting to hide the close button from the recording window#98
Add setting to hide the close button from the recording window#98papadi wants to merge 4 commits intotom-englert:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new user setting to control the visibility of the close button in the recording window. The close button can be annoying when sharing the upper right corner of the screen as it may overlap with other window's close buttons. Users can now hide it via a checkbox in the main window settings, while still being able to close the region using the taskbar.
Changes:
- Added a new
ShowCloseButtonuser setting with a default value ofTrueto preserve existing behavior - Bound the close button's visibility in the recording window to this setting using
BooleanToVisibilityConverter - Added a "Show close button" checkbox in the main window for users to toggle this setting
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/RegionToShare/RecordingWindow.xaml | Added namespace import for properties, added BooleanToVisibilityConverter resource, and bound close button visibility to ShowCloseButton setting |
| src/RegionToShare/Properties/Settings.settings | Added ShowCloseButton boolean setting with default value True |
| src/RegionToShare/Properties/Settings.Designer.cs | Auto-generated property accessor for ShowCloseButton setting |
| src/RegionToShare/MainWindow.xaml | Added checkbox UI control to toggle ShowCloseButton setting |
| src/RegionToShare/App.config | Added ShowCloseButton configuration entry with default value True |
Files not reviewed (1)
- src/RegionToShare/Properties/Settings.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This is incomplete. There's no way to return to the main window this way. |
…ack to main using the taskbar.
|
Ok, problem fixed. Now when recording starts the main window is hidden from taskbar and the recoding window appears on taskbar. If that closes then we are back to main window which reappears on taskbar. |
Close button in the recording window is often annoying, especially when sharing the upper right corner, since it overlaps with the close button of another window. Anyway, it is possible to close the region using the taskbar. Default value of the new setting will not change the original bevaviour.