feat: main branch for the existing keys, tasks, imports, language stats#3430
Open
feat: main branch for the existing keys, tasks, imports, language stats#3430
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dkrizan
requested changes
Jan 29, 2026
backend/data/src/main/kotlin/io/tolgee/component/demoProject/DemoProjectCreator.kt
Show resolved
Hide resolved
| WHERE ls2.language_id = ls.language_id AND ls2.branch_id = b.id | ||
| ); | ||
| </sql> | ||
| </changeSet> |
Contributor
There was a problem hiding this comment.
In this case we can make Key.branch not-null, right ?
Contributor
Author
There was a problem hiding this comment.
i guess the same is for tasks and imports. However language_stats seems differnt
Contributor
Author
There was a problem hiding this comment.
added those constraints
dkrizan
force-pushed
the
danielkrizan/branching
branch
from
5d67e55 to
4c8a46c
Compare
bdshadow
force-pushed
the
dbocharov/branching/migrate-to-default-branch
branch
from
58d0858 to
84062af
Compare
… handle branch in services
…load (branch name in url)
…on-deleted branch
…`, streamline branch ID resolution, and refactor snapshot logic to avoid lazy loading issues
…c for namespace display
…nd ensure accurate state persistence
…ith updated backend logic and comprehensive test coverage
… data setup, and refactor branching logic
…anching feature flag
…anching feature flag
…enhance branching assertions
… both branches during merge dry-run
dkrizan
force-pushed
the
danielkrizan/branching
branch
from
a6ad058 to
e9037a6
Compare
…uplicate stats properly
…nd improving label resolution logic
…e for both backend and e2e
…ng single change updates
- Add DefaultBranchNotFoundException for consistent error handling - Make Key.branch, Task.branch, and Import.branch non-nullable (JPA optional=false) - Update BranchService methods to return non-null Branch - Add automatic default branch creation in test data builders - Simplify SecurityService and BranchVersionedEntity branch access Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
bdshadow
force-pushed
the
dbocharov/branching/migrate-to-default-branch
branch
from
84062af to
d4a618e
Compare
dkrizan
force-pushed
the
danielkrizan/branching
branch
from
594f365 to
29f7614
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.