Use Ok and Some variants in tokio::select! from shutdown example#819
Open
aaw5017 wants to merge 1 commit intotokio-rs:masterfrom
Open
Use Ok and Some variants in tokio::select! from shutdown example#819aaw5017 wants to merge 1 commit intotokio-rs:masterfrom
aaw5017 wants to merge 1 commit intotokio-rs:masterfrom
Conversation
- use the `Ok` variant for `signal::ctrl_c()` - use the `Some` variant for `shutdown_recv.recv()` Adding these variants to the matcher should alleviate issues that a copy/paster might run into while running the examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okvariant forsignal::ctrl_c()Somevariant forshutdown_recv.recv()Adding these variants to the matcher should alleviate issues that a copy/paster might encounter while running the examples.