Skip to content

io: add tokio_util::io::simplex - #7565

Merged
ADD-SP merged 36 commits into
tokio-rs:masterfrom
ADD-SP:add_sp/io-alt-simplex
Dec 18, 2025
Merged

io: add tokio_util::io::simplex#7565
ADD-SP merged 36 commits into
tokio-rs:masterfrom
ADD-SP:add_sp/io-alt-simplex

Conversation

@ADD-SP

@ADD-SP ADD-SP commented Aug 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Design document

https://gist.github.com/ADD-SP/7558ef3965f18ce1d721dff675d01d9b

Why not deprecate the tokio::io::simplex now?

Since the deprecation is not urgent, we can release this feature and first, and the deprecate the tokio::io::simplex after several months.

issue: #7548

@ADD-SP ADD-SP added C-enhancement Category: A PR with an enhancement or bugfix. A-tokio-util Area: The tokio-util crate M-io Module: tokio/io labels Aug 31, 2025
@ADD-SP
ADD-SP force-pushed the add_sp/io-alt-simplex branch 3 times, most recently from ee6ae5a to c8a39fb Compare August 31, 2025 03:45
@ADD-SP
io: add tokio_util::io::simplex
43805ab 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
ADD-SP force-pushed the add_sp/io-alt-simplex branch from c8a39fb to 43805ab Compare August 31, 2025 04:48
Darksonn
Darksonn reviewed Sep 2, 2025
View reviewed changes
Comment thread tokio-util/Cargo.toml Outdated
Comment thread tokio-util/src/io/simplex.rs Outdated
Comment thread tokio-util/src/io/simplex.rs Outdated
@ADD-SP
merge: sync changes from the base branch
0274aed 
base is c8371d4
@ADD-SP
io: unlock before waking up
5b8b019 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
io: make Inner::with_capacity more "with_capacity"
afc7e07 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP ADD-SP mentioned this pull request Sep 7, 2025
Merged
martin-g
martin-g reviewed Oct 30, 2025
View reviewed changes
Comment thread tokio-util/src/io/simplex.rs
Comment thread tokio-util/src/io/simplex.rs Outdated
ADD-SP added 7 commits November 5, 2025 19:29
@ADD-SP
merge: sync changes from the base branch
4ffa045
@ADD-SP
do not include tokio/rt by default
585a957 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
panics on zero capacity
f6fc30a 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
poll_shutdown should be called multiple times without error
41665dc 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
wake up the receiver on shutdown
6eafcd1 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
wake up the receiver after dropping the sender
95837ba 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
wake up the sender after dropping the receiver
d7f6d20 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
ADD-SP requested review from Darksonn and martin-g November 5, 2025 12:26
martin-g
martin-g reviewed Nov 5, 2025
View reviewed changes
Comment thread tokio-util/src/io/simplex.rs
Comment thread tokio-util/src/io/simplex.rs Outdated
Comment thread tokio-util/tests/io_simplex.rs
Comment thread tokio-util/tests/io_simplex.rs Outdated
Comment thread tokio-util/tests/io_simplex.rs
Comment thread tokio-util/src/io/simplex.rs
Comment thread tokio-util/src/io/simplex.rs
@martin-g

martin-g commented Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Both the issue and the implementation (this PR) do not say anything about vectored writes (https://docs.rs/tokio/1.48.0/src/tokio/io/util/mem.rs.html#387-400)
Are they omitted intentionally ?

ADD-SP added 4 commits November 5, 2025 22:29
@ADD-SP
fix hang forever issues
1e30455 
1. The `Sender` should not hang forever when the input buf is empty
2. The `Receiver` should not hange forever when the input buf is full

Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
unify the error message
53c6d81 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
add more tests
6eb9659 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
merge: sync changes from the base branch
2225999
@ADD-SP
support poll_write_vectored
45976a9 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
ADD-SP requested a review from martin-g November 5, 2025 15:25
martin-g
martin-g reviewed Nov 6, 2025
View reviewed changes
Comment thread tokio-util/src/io/simplex.rs
Comment thread tokio-util/src/io/simplex.rs Outdated
Comment thread tokio-util/src/io/simplex.rs
ADD-SP added 3 commits November 6, 2025 19:21
@ADD-SP
fix typos
d35012b 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
adopt coop for poll_write_vectored
d9809a8 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
merge: sync changes from the base branch
439a4aa
@github-actions github-actions Bot added the R-loom-util Run loom tokio-util tests on this PR label Nov 6, 2025
ADD-SP added 2 commits November 6, 2025 19:45
@ADD-SP
fix rustfmt reports
f954e93 
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP
merge: sync changes from the base branch
34e3a42
martin-g
martin-g approved these changes Nov 10, 2025
View reviewed changes
Comment thread tokio-util/src/io/simplex.rs
Darksonn
Darksonn reviewed Nov 11, 2025
View reviewed changes
Comment thread tokio-util/src/io/simplex.rs Outdated
Comment thread tokio-util/src/io/simplex.rs Outdated
@ADD-SP
ADD-SP requested a review from Darksonn November 20, 2025 01:55
@ADD-SP
ADD-SP merged commit 064181f into tokio-rs:master Dec 18, 2025
88 checks passed
@ADD-SP
ADD-SP deleted the add_sp/io-alt-simplex branch December 18, 2025 12:35
@Darksonn Darksonn mentioned this pull request Jan 4, 2026
Merged
@mattiapitossi mattiapitossi mentioned this pull request Jan 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-g martin-g martin-g approved these changes
@Darksonn Darksonn Awaiting requested review from Darksonn

Assignees

No one assigned

Labels

A-tokio-util Area: The tokio-util crate C-enhancement Category: A PR with an enhancement or bugfix. M-io Module: tokio/io R-loom-util Run loom tokio-util tests on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ADD-SP @martin-g @Darksonn