fix: Handle upper-scope generics in __AnonymousParselet__ - #171
Merged
Conversation
... and detect problem, which is that inline parselets don't have generics setting, so both the fast-lane and the final check fails. Removing these checks will build the correct program, which is the case with this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix #166 was not complete to resolve #130, when it came to resolving generics inside of anonymous parselets inside parselets defining the generics.
The current compiler implementation is a little bit error-prone. This PR introduces a fix that handled the case reproducible by
which is a development step case of #133 and the input