Merged
Conversation
This commit linkifies the task title. It supports not only links, but also mail addresses. It applies to the task list as well as the task details. Closes: tmahmood#33
tmahmood
reviewed
May 10, 2025
Owner
tmahmood
left a comment
tmahmood
left a comment
There was a problem hiding this comment.
We can also linkfy annotations?
| @@ -244,6 +246,34 @@ fn strip_prefix() -> impl tera::Function { | |||
| ) | |||
| } | |||
|
|
|||
Owner
There was a problem hiding this comment.
Even the links are clickable, they are not differentiable from normal text. Adding link class should do the job
Contributor
Author
There was a problem hiding this comment.
Good point. I've added it. As link seems to be used only dynamically it didn't worked at the beginning and therefore i've put it now to the safelist of tailwind.
This commit add linkification to the annotations as well and is ensuring, the links are visible. Closes: tmahmood#33
tmahmood
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit linkifies the task title. It supports not only links, but also mail addresses.
It applies to the task list as well as the task details.
Closes: #33