Skip to content

Fix: Considerung various more fields for upd/new#36

Merged
tmahmood merged 2 commits intotmahmood:mainfrom
monofox:bugfix/modify_depends
May 13, 2025
Merged

Fix: Considerung various more fields for upd/new#36
tmahmood merged 2 commits intotmahmood:mainfrom
monofox:bugfix/modify_depends

Conversation

@monofox
Copy link
Copy Markdown
Contributor

@monofox monofox commented May 10, 2025

This commit introduces support of various fields, which got dropped on usage of taskchampion.

Closes #35

This commit introduces support of various fields, which got
dropped on usage of taskchampion.

Closes tmahmood#35
@monofox
Copy link
Copy Markdown
Contributor Author

monofox commented May 10, 2025

Actually i regret a bit of introducing taskchampion. It is really cool in order to ensure some kind of better interaction, but the problem is, that taskwarrior and taskchampion are not consistent in the validation.

taskwarrior is sometimes something interpreting which does not make sense, but supports command in order to set various fields automatically and validating and translating e.g. due timestamps, while taskchampion focus on storage and requires already valid data, but it does not check for consistency.

Not happy on.

@tmahmood
Copy link
Copy Markdown
Owner

Hm, for now what we can do is, when there are entries in additional options, use task warrior command, otherwise use taskchampion. That way we keep both. I know, it is an ugly hack, but it gets the thing done

This commit fix a small warning in the tests.

Closes: tmahmood#35
@monofox
Copy link
Copy Markdown
Contributor Author

monofox commented May 11, 2025

for now what we can do is, when there are entries in additional options, use task warrior command, otherwise use taskchampion.

Actually this is not as easy and will bring new side effects. This is the reason, why i've made manual support for now on the corresponding most features. With this we get some time to think about it.

@tmahmood tmahmood merged commit 62c861c into tmahmood:main May 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: setting various special fields do not proper work anymore

2 participants