compileopts: add noasm default build tag#5305
Open
jakebailey wants to merge 1 commit intotinygo-org:devfrom
Open
compileopts: add noasm default build tag#5305jakebailey wants to merge 1 commit intotinygo-org:devfrom
jakebailey wants to merge 1 commit intotinygo-org:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this is a good idea or not, but, this affects github.com/zeebo/xxh3 and github.com/klauspost/cpuid/v2 which both fail to compile with tinygo unless their asm is disabled (at least for amd64 where I was testing). I am not 100% familiar with what asm tinygo supports, but my impression was that it handles none, hence setting
purego? Unclear why these packages don't just usepurego.(Happy to just not do this and keep the build tag to myself if that is more acceptable, I'm just splitting apart a chain of commits in the process of getting tsgo working).
Updates #4894