Align pi-supervisor status, defaults, and docs#2
Open
shanelindsay wants to merge 1 commit intotintinweb:masterfrom
Open
Align pi-supervisor status, defaults, and docs#2shanelindsay wants to merge 1 commit intotintinweb:masterfrom
shanelindsay wants to merge 1 commit intotintinweb:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aligns pi-supervisor terminology and UI/docs around a goal-focused supervision concept, while improving runtime defaults persistence and preventing idle supervisor decisions from stalling the run.
Changes:
- Updates user-facing wording from “outcome” to “goal” across UI text, notifications, and documentation.
- Persists model/provider and sensitivity selections as session-scoped defaults for the next
/supervise, even when supervision is inactive. - Converts idle
continuesupervisor decisions into asteersoagent_endruns don’t stall.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates commands/terminology and documents defaults + idle-continue behavior. |
| src/index.ts | Implements default resolution via persisted prefs, updates command behavior/copy, and applies prefs during tool-initiated starts. |
| src/state.ts | Adds persisted supervisor prefs alongside persisted supervisor state. |
| src/types.ts | Introduces SupervisorPrefs type for session-scoped defaults. |
| src/engine.ts | Converts idle continue into steer to avoid stalled runs. |
| src/ui/settings-panel.ts | Renames the active field label from “Outcome” to “Goal”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
399
to
406
| @@ -397,8 +406,8 @@ export default function (pi: ExtensionAPI) { | |||
| } else { | |||
Comment on lines
424
to
425
| "info" | ||
| ); |
Comment on lines
+233
to
+237
| if (agentIsIdle && decision.action === "continue") { | ||
| return { | ||
| action: "steer", | ||
| message: "Please continue working toward the goal.", | ||
| reasoning: decision.reasoning || "Idle continue converted to steer", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/supervisecontinueresponses from leaving the run stalledDetailed breakdown
README.mdsrc/index.tsgoalrather thanoutcome/supervise statusopen settings when activesrc/state.tsandsrc/types.tssrc/engine.tscontinuedecisions into a steer so the run does not stallsrc/ui/settings-panel.tsOutcometoGoalTesting