Add support for Shadow DOM parents - #646
Open
dermotduffy wants to merge 1 commit into
Open
Conversation
Author
|
@timmywil Gentle ping -- any thoughts on this PR? |
Panzoom already works inside shadow DOM, but not when the element's parent is the shadow root host -- i.e. when the library is used at the top level of a web component. Resolve the parent via `getParentElement`, which falls back to the shadow root host, in place of reading `parentNode` directly.
dermotduffy
force-pushed
the
shadow-dom-parent
branch
from
July 27, 2026 03:34
6cc9eb6 to
679dd20
Compare
Author
|
PR updated for June 2026. Still valid. |
dermotduffy
added a commit
to dermotduffy/panzoom
that referenced
this pull request
Jul 27, 2026
This fork carries shadow root host support, which upstream has not taken (timmywil#646). Rename so it can be published alongside the upstream package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please review the guidelines for contributing to this repository.
yarn testagainst my changes and tests pass.test/unit/or a new or altered demo indemo/.yarn docs), or no docs changes are needed.Description
Add support for the parent element being a Shadow Root host. Right now, this library will support elements in Shadow DOM, but not if the parent element is the shadow root host (i.e. use of this library at the top-level of a web component).
Also includes very minor typing fixes/clarifications.
Fixes: #