resourcegroup: replace blind sleep with signal-aware wait in acquireTokens (#10252)#10505
Conversation
close tikv#10251 Signed-off-by: ti-chi-bot <[email protected]>
|
@JmPotato This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This reverts commit c6ce272. Signed-off-by: JmPotato <[email protected]>
…okens (cherry picked from commit 961bd132b28f6345af0df288a33741f9c7dcfd2e) Signed-off-by: JmPotato <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
|
/retest |
1 similar comment
|
/retest |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (59.37%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-8.5-20260323-v8.5.5 #10505 +/- ##
===============================================================
- Coverage 77.98% 77.85% -0.14%
===============================================================
Files 482 482
Lines 65391 65419 +28
===============================================================
- Hits 50997 50932 -65
- Misses 10665 10747 +82
- Partials 3729 3740 +11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #10252
What problem does this PR solve?
Issue Number: close #10251.
What is changed and how does it work?
Check List
Tests
Release note
Summary by CodeRabbit
Bug Fixes
New Features
Tests