test: distinguish MustHandleStoreHeartbeat #10092
Conversation
ti-chi-bot
bot
added
release-note-none
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10092 +/- ##
==========================================
- Coverage 78.38% 78.36% -0.02%
==========================================
Files 518 518
Lines 69476 69476
==========================================
- Hits 54456 54446 -10
- Misses 11066 11070 +4
- Partials 3954 3960 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ti-chi-bot
bot
added
needs-1-more-lgtm
You can add more comments here to detail why removing this forwarding.
|
|
/retest |
| func MustHandleStoreHeartbeat(re *require.Assertions, cluster *TestCluster, heartbeat *pdpb.StoreHeartbeatRequest) { | ||
| err := cluster.GetLeaderServer().GetRaftCluster().HandleStoreHeartbeat(heartbeat, &pdpb.StoreHeartbeatResponse{}) | ||
| re.NoError(err) | ||
| if cluster.GetSchedulingPrimaryServer() != nil { |
There was a problem hiding this comment.
We have sync storeheartbeat between mcs and pd, we should not duplicate forward it in test.
After removing it, these tests still are successful.
Signed-off-by: lhy1024 <[email protected]>
lhy1024
changed the title
ti-chi-bot
bot
added
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
1 similar comment
|
/retest |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/test pull-unit-test-next-gen-3 |
1 similar comment
|
/test pull-unit-test-next-gen-3 |
|
/retest |
1 similar comment
|
/retest |
|
/test pull-unit-test-next-gen-3 |
|
/test pull-unit-test-next-gen-2 |
ref tikv#4399 Signed-off-by: lhy1024 <[email protected]>
3 participants
What problem does this PR solve?
Issue Number: Ref #4399
What is changed and how does it work?
When we need to test statistics, we need to forward store heartbeat to scheduling server.
If we only test store metadata, we only use store watcher and not need to forward store heartbeat.
Check List
Tests
Release note