Skip to content

chore(test): migrate the integration tests for ota_metadata to follow new test layout#927

Merged
Bodong-Yang merged 4 commits into
mainfrom
worktree-chore+migrate_integration_ota_metadata
May 19, 2026
Merged

chore(test): migrate the integration tests for ota_metadata to follow new test layout#927
Bodong-Yang merged 4 commits into
mainfrom
worktree-chore+migrate_integration_ota_metadata

Conversation

@Bodong-Yang
Copy link
Copy Markdown
Member

@Bodong-Yang Bodong-Yang commented Apr 27, 2026

Introduction

This PR migrates the integration tests part of existed tests for ota_metadata package to follow the new test layout.

Bodong-Yang and others added 2 commits April 27, 2026 11:01
Migrate the three legacy ota_metadata integration tests
(`test_ca_store`, `test_legacy2/test_csv_parser`,
`test_ota_image_v1/test_cert_verification`) to the new
`test/integration/test_ota_metadata/` layout.

Conventions applied per MIGRATION_PLAN §3:
- `gen_certs.sh` relocated to subtree-local
  `test/integration/test_ota_metadata/keys/`, scoped to the smallest
  subtree that consumes it.
- `/ota-image` container dependency declared in a local
  `test_legacy2/conftest.py`.
- Imports from `tests.conftest` removed; `TEST_DIR` and
  `TestConfiguration` references replaced with `Path(__file__)`-based
  locals or local-conftest constants.
- Unused `TEST_BASE_SIGN_PEM` reference dropped.

Test bodies are otherwise preserved verbatim. All 13 cases pass under
`docker/test_base/docker-compose_tests_py313.yml`.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@Bodong-Yang Bodong-Yang added chore Pull requests that do not relate to a fix or feature and don't modify source code(like tagging, etc) test_files Add/change test files labels Apr 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

📊 OTA Update Performance Comparison Report

Generated: 2026-05-19T00:43:13.145006

⏱️ Execution Time

Phase Legacy (s) V1 (s)
Total Duration 27.9 27.3
Metadata Processing 2.0 2.0
Delta Calculation 12.0 10.0
Download 2.0 3.0
Apply Update 6.0 7.0
Post Update 0.0 0.0
Finalization 0.0 0.0

@Bodong-Yang Bodong-Yang changed the title chore(test): migrate tests for ota_metadata to follow new test layout chore(test): migrate the integration tests for ota_metadata to follow new test layout May 13, 2026
@Bodong-Yang Bodong-Yang marked this pull request as ready for review May 18, 2026 08:49
@Bodong-Yang Bodong-Yang requested review from a team as code owners May 18, 2026 08:49
@sonarqubecloud
Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@Bodong-Yang Bodong-Yang self-assigned this May 18, 2026
Copy link
Copy Markdown
Collaborator

@airkei airkei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bodong-Yang Bodong-Yang enabled auto-merge (squash) May 19, 2026 00:41
@sonarqubecloud
Copy link
Copy Markdown

@Bodong-Yang Bodong-Yang merged commit cbf2920 into main May 19, 2026
11 checks passed
@Bodong-Yang Bodong-Yang deleted the worktree-chore+migrate_integration_ota_metadata branch May 19, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests that do not relate to a fix or feature and don't modify source code(like tagging, etc) test_files Add/change test files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants