Conversation
Member
|
Wow, excellent work! |
Contributor
|
Very good. I was just about to ask how things were going on with target API level 36... |
Collaborator
|
Is the app icon <> title spacing also that way natively? It clips to the app icon |
Contributor
Author
|
Don't think so, but this is how it looks with the current SDK too if I remember correctly. Ti also still use Actionbars in some places. We would need to move all those to Toolbars to have a better look in general. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(hopefully) fixes #14353
Targeting Android SDK 36 will remove the current opt-out XML for the edge-to-edge stuff and this will break our layouts:
(Ti 13.1.1.GA with targetSDK 36)
Whats fixed:
This PR will remove the opt-out part from the XML file, adds a new
EdgeToEdgeHelperthat will set the correct padding and fixes the (current/old) BottomNavigation height calculation. Otherwise the views are slightly behind the bottom navigation again. Theexperimental:true(new) BottomNavigation using the XML is working fine.(this PR)
How to test it
<uses-sdk android:targetSdkVersion="36" />in the<manifest>node in your tiapp.xmlSome images:
Notes:
This will make sure a bottomnavigation will be behind the navigation bar BUT the content will stay above it. So it technically is not using edge-to-edge in order to make existing apps look the same without any changes. It is not using safeArea or allows content behind the bottom navigation. This should be implemented at some point. But this PR will just make sure we have something that is Android SDK 36 ready once there is a requirement by Google!
Removing the current bottom padding for normal windows will make them look like this:

so you have to make sure to set a proper bottom position (like iOS)