Feat: Implement farms provider and background preloading#1096
Open
zaelgohary wants to merge 1 commit intodevelopment_app_layoutfrom
Open
Feat: Implement farms provider and background preloading#1096zaelgohary wants to merge 1 commit intodevelopment_app_layoutfrom
zaelgohary wants to merge 1 commit intodevelopment_app_layoutfrom
Conversation
AlaaElattar
reviewed
Jun 22, 2025
| } | ||
| } | ||
|
|
||
| final preloadingServiceProvider = Provider<PreloadingService>((ref) { |
Contributor
There was a problem hiding this comment.
why don't we return
final preloadingServiceProvider = Provider<PreloadingService>((ref) {
return PreloadingService(
ref.read(walletsNotifier.notifier),
ref.read(farmsNotifier.notifier)
);
});
directly from here.
What do u think ?
Contributor
Author
There was a problem hiding this comment.
But why? The PreloadingService uses a singleton pattern which ensures there is only one instance of it throughout the app. It's a simpler approach and we avoid creating multiple instances.
AlaaElattar
reviewed
Jun 22, 2025
| if (!_reload) return; | ||
| if (!_loading && _isListed) { | ||
| try { | ||
| final wallets = <Wallet>[]; |
Contributor
There was a problem hiding this comment.
- Why passing empty list ? we can pass the wallets from walletsNotifier.
Contributor
Author
There was a problem hiding this comment.
I'm resetting the state before using refresh from wallet provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Performance improvements:
Related Issues
#1036
Tested Scenarios