[pull] main from VirusTotal:main#218
Merged
Merged
Conversation
Items in the type list are 16-bits values but were being parsed as 32-bits.
These are sanity checks against corrupted DEX files that can cause out-of-memory errors.
This commit refactors the DEX module parser to ensure strict compliance with the DEX specification, and resolve potential parsing failures on obfuscated or padded files. * Refactored table parser signatures (`parse_strings`, `parse_types`, `parse_protos`, `parse_fields`, `parse_methods`, `parse_class_defs`) to eliminate intermediate `xxx_offset` remainder slices. Functions now receive the complete data buffer and `DexHeader`, returning `Vec` directly. * Implemented absolute table offset lookups (`data.get(header.table_off..)`) across all table parsers instead of sequential `remainder` parsing. This prevents misalignment and out-of-bounds errors on DEX files containing section padding or rearranged tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )