[pull] master from apify:master#203
Merged
Merged
Conversation
#3673) `BrowserPool.newPage()` serializes calls through `pLimit(1)`. `p-limit` resumes queued callbacks in the previous task's AsyncLocalStorage context, so a queued `newPage` call can inherit a sibling's aborted `cancelTask` and its first `tryCancel()` throws `InternalTimeoutError` pre-emptively. This fix explicitly passes the correct `AsyncLocalStorage` context into the `pLimit` arrow function to ensure task isolation. Closes #3670
The \`cheerio-enqueue-links-base\` and \`playwright-enqueue-links-base\` actors crawled \`https://www.jamesallen.com/faq/\`, which was already flaky and recently changed structure entirely — the cheerio variant has been failing on every scheduled E2E run, and the playwright one was already skipped as \`too flaky\`. Replace the third-party dependency with a self-contained \`node:http\` server (no extra deps) started inside each actor. The fixture serves a \`/start\` page with \`<base href="/sub/">\` and a handful of relative + one absolute link, plus the linked pages. The crawler enqueues with a glob restricting to \`/sub/**\`, so base-href correctness determines whether the relative links match and get enqueued — expected dataset size is 4 (start + 3 sub pages), 1 if base-href handling is broken. Verified the negative case by temporarily disabling the \`<base>\` branch in \`extractUrlsFromCheerio\` and confirming the test fails. Also unskips the playwright variant (its flakiness was the external site) and drops \`proxyConfiguration\` since localhost shouldn't be proxied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )