Skip to content

Update error messaging#112

Merged
Rifdhan merged 1 commit intomainfrom
update-error-messaging
Apr 15, 2026
Merged

Update error messaging#112
Rifdhan merged 1 commit intomainfrom
update-error-messaging

Conversation

@Rifdhan
Copy link
Copy Markdown
Collaborator

@Rifdhan Rifdhan commented Apr 13, 2026

  • Provide a meaningful message instead of the raw error response

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces dynamic error messages with static user-facing strings when creating answers, liveboards, and dashboards in the MCPServer. The review feedback highlights that the new messages are potentially misleading because they attribute all failures to user input, which could be incorrect in the event of server-side or connectivity issues. It is recommended to use more neutral wording that accounts for various error sources.

Comment thread src/servers/mcp-server.ts
Comment thread src/servers/mcp-server.ts
Comment thread src/servers/mcp-server.ts
- Provide a meaningful message instead of the raw error response
@Rifdhan Rifdhan force-pushed the update-error-messaging branch from e588717 to bb5007c Compare April 14, 2026 00:01
@Rifdhan Rifdhan merged commit 44dc4ff into main Apr 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants