Conversation
Collaborator
Rifdhan
commented
Apr 13, 2026
- Provide a meaningful message instead of the raw error response
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces dynamic error messages with static user-facing strings when creating answers, liveboards, and dashboards in the MCPServer. The review feedback highlights that the new messages are potentially misleading because they attribute all failures to user input, which could be incorrect in the event of server-side or connectivity issues. It is recommended to use more neutral wording that accounts for various error sources.
- Provide a meaningful message instead of the raw error response
e588717 to
bb5007c
Compare
shikharbsar
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.