Migrate MapFromFunc from Hecke->AbstractAlgebra - #2290
Open
mjrodgers wants to merge 13 commits into
Open
Conversation
fingolfin
reviewed
Jul 8, 2026
| else | ||
| F = t | ||
| mF = MapFromFunc(parent(p), F, x->F(x), y->lift(y)) | ||
| mF = map_from_func(parent(p), F, x->F(x), y->lift(y)) |
Contributor
There was a problem hiding this comment.
Can't we also do this? But ok, not in the scope for this PR
Suggested change
| mF = map_from_func(parent(p), F, x->F(x), y->lift(y)) | |
| mF = map_from_func(parent(p), F, F, lift) |
fingolfin
reviewed
Jul 8, 2026
Comment on lines
10
to
11
| preimage_function(f) = a -> preimage(f, a) | ||
| image_function(f) = a -> image(f, a) |
Contributor
There was a problem hiding this comment.
These could also be removed if we add explicit image and preimage methods to InverseMap. Should we also move InverseMap to AA?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Paired with 2443)
As discussed in 6043, there is some motivation to move
MapFromFuncfrom Hecke into AbstractAlgebra, at least partially so that it can be used inGAP.jl/NemoExt(we hope to migrate some of theiso_oscar_gap/iso_gap_oscarfunctionality to there.To facilitate this, the following things have been moved:
HeckeMap,MapFromFuncMapHeaderMapCacheand some related/supporting functions.
We will also move some related tests, and rewrite some code using
AbstractAlgebra.map_from_func(which creates aGeneric.FunctionalMap) to useMapFromFuncinstead.