Add iop feature teardown for --remove-feature - #783
Draft
jeremylenz wants to merge 3 commits into
Draft
Conversation
jeremylenz
force-pushed
the
iop-remove-feature-teardown
branch
from
August 25, 2026 19:00
972dbcc to
c101d50
Compare
9 tasks
Co-Authored-By: Claude <noreply@anthropic.com>
Implements actual teardown logic when iop is removed: stops container services, removes quadlet files, secrets, volumes, the podman network, frontend assets, Apache configs, downloader scripts, and FDW database objects in advisor_db and vulnerability_db. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> (cherry picked from commit 972dbcc)
The dev tree has its own copies of the _flavor_features metadata and its own deploy-dev play, so the production-side feature-removal support did not reach forge. Add the remove_features parameter to the dev _flavor_features metadata and include the iop_remove role in the deploy-dev play so `forge deploy-dev --remove-feature iop` parses and tears down IOP. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jeremylenz
force-pushed
the
iop-remove-feature-teardown
branch
from
August 31, 2026 13:58
c101d50 to
4f9c57c
Compare
Contributor
Author
|
draft until #746 is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
--remove-feature ioppreviously did nothing to deployed iop services. This implements the actual teardown logic. Depends on / relates to #746 (which provides theremove_featuresvariable); without that PR merging,remove_featuresdefaults to[]and this role is a no-op.update: Now includes the commit from #746, temporarily.
What are the changes introduced in this pull request?
iop_removerole that stops all iop container services, removes quadlet files, secrets, volumes, the podman network, frontend assets, Apache configs, downloader scripts/data, and cleans up FDW database objects in advisor_db and vulnerability_dbiop_removeinto the deploy playbook, running when'iop' in remove_featuresiopfeature asremovable: trueinsrc/features.yamlHow to test this pull request
Steps to reproduce:
./foremanctl deploy --add-feature iopor./forge deploy-dev --add-feature iopand make sure that succeeds./foremanctl deploy --remove-feature iopor./forge deploy-dev --remove-feature iop(requires Add feature removal validation and removability metadata #746)