Fixes #39142 - skip compute orchestration for unmanaged hosts#10905
Open
jakduch wants to merge 1 commit intotheforeman:developfrom
Open
Fixes #39142 - skip compute orchestration for unmanaged hosts#10905jakduch wants to merge 1 commit intotheforeman:developfrom
jakduch wants to merge 1 commit intotheforeman:developfrom
Conversation
Add managed? guard to queue_compute to prevent compute orchestration from running on unmanaged hosts registered via Global Registration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a host is registered via Global Registration (managed: false), the compute orchestration in
queue_computestill runs, attempting to create/update a VM on the compute resource. This causes errors for hosts that are not meant to be managed by Foreman's compute layer.This patch adds a
managed?guard toqueue_computeso that compute orchestration is skipped for unmanaged hosts.The
queue_compute_destroymethod intentionally does NOT get this guard — VM cleanup should work for all hosts regardless of managed status, as confirmed by existing tests inHost::ManagedTest::deletion.Testing: