Refs #38173 - correct variable name to ntp_server#10873
Merged
ofedoren merged 1 commit intotheforeman:3.18-stablefrom Feb 19, 2026
Merged
Refs #38173 - correct variable name to ntp_server#10873ofedoren merged 1 commit intotheforeman:3.18-stablefrom
ntp_server#10873ofedoren merged 1 commit intotheforeman:3.18-stablefrom
Conversation
pr-processor
bot
added
Not yet reviewed
Stable branch
Gauravtalreja1
approved these changes
Feb 19, 2026
ofedoren
approved these changes
Feb 19, 2026
Member
ofedoren
left a comment
ofedoren
left a comment
There was a problem hiding this comment.
A bit weird to see Refs here, but 🤷
Member
Author
Why? That's the Redmine that introduced the bug and it was not in a stable release yet. |
Contributor
|
Separately, it is a bit weird to see this wasn't caught by the unit tests. Should those be updated to ensure the problem doesn't return? |
Member
Author
|
Yeah, we don't test that specific branch (rhel6 or @shubhamsg199 caught it in Satellite tests tho :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: c9d6db8
(cherry picked from commit 7a2fc6c)