Skip to content

Comments

Refs #38173 - correct variable name to ntp_server#10872

Merged
evgeni merged 1 commit intotheforeman:developfrom
evgeni:ntp-fix
Feb 19, 2026
Merged

Refs #38173 - correct variable name to ntp_server#10872
evgeni merged 1 commit intotheforeman:developfrom
evgeni:ntp-fix

Conversation

@evgeni
Copy link
Member

@evgeni evgeni commented Feb 19, 2026

Fixes: c9d6db8

-%>
<% if use_ntp -%>
yum -y install ntpdate
<% if ntp-server -%>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the header it still says - ntp-server: string (default=undef)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the host param is still called ntp-server, but not the variable in the erb template:

ntp_server = host_param('ntp-server')

Copy link
Contributor

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.Thanks.

Copy link

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, Tested and I don't see any more render template errors

@evgeni evgeni merged commit 7a2fc6c into theforeman:develop Feb 19, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants