Skip to content

Fixes #38998 - Deprecate pf3 select form field#10818

Merged
ofedoren merged 1 commit intotheforeman:developfrom
MariaAga:depreacte-select-pf3
Jan 29, 2026
Merged

Fixes #38998 - Deprecate pf3 select form field#10818
ofedoren merged 1 commit intotheforeman:developfrom
MariaAga:depreacte-select-pf3

Conversation

@MariaAga
Copy link
Member

depends on #10817

No longer used anywhere and there are alternatives.

Checked that its not used in:

  • templates (only use these input types: 'plain', 'search', 'date','resource')
  • react_form_input
  • InputFactory
  • FormField

@MariaAga MariaAga requested a review from a team as a code owner January 15, 2026 10:57
@github-actions github-actions bot added the UI label Jan 15, 2026
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it really deprecate or just replaces the component with deprecation notice?

I mean, deprecation means "you still can use it, but it's not recommended since it will be gone in 1-2 releases"

Currently it seems like after this PR no one will be able to use the old Select component.

If we change this PR to actually add the deprecation without removal, we can drop other commits so it doesn't depend on anything and get it merged sooner.

@MariaAga MariaAga force-pushed the depreacte-select-pf3 branch from 9d8131e to cfcaf1c Compare January 29, 2026 10:44
@MariaAga
Copy link
Member Author

Thanks for clarifying! do we have it documented somewhere?

@ofedoren
Copy link
Member

do we have it documented somewhere?

You mean information about deprecations?

I guess we can follow

All of the three suggest 2-3 releases before actual removal.

Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to go, thanks, @MariaAga !

@ofedoren ofedoren merged commit d9ac1d8 into theforeman:develop Jan 29, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants