Fixes 38993: add OpenVox repository

[d1nuc0m]

Add OpenVox repository when relevant parameters are in use.

[bastelfreak]

I haven't tested this, but the changes look correct to me

[ekohl]

I think this will mean it runs both Puppet and OpenVox setup. In app/views/unattended/provisioning_templates/user_data/userdata_default.erb you solved it with a force-puppet parameter and IMHO this part should be aligned.

[d1nuc0m]

Thinking about it maybe it should be like this:

• if Puppet is explicitly forced, install it
• Otherwise, default to OpenVox (instead of Puppet) if a Puppet Server is present and OpenVox setup is not explicitly skipped; or if OpenVox setup is forced

Btw, which should be the proper way to add an exception in case both force-puppet and force-openvox are true?

[d1nuc0m]

And, is there a way to add tests to templates?

[ekohl]

Thinking about it maybe it should be like this:

I think that's good

Btw, which should be the proper way to add an exception in case both force-puppet and force-openvox are true?

I'd also be OK with just assuming OpenVox then. In environments where Katello is used you control the availability via synced content anyway and it's irrelevant. You only need the configuration to be done.

And, is there a way to add tests to templates?

We render snapshots, so that can be used. It's a fairly heavy process though because it usually results in huge files to be included.

[d1nuc0m]

I'd also be OK with just assuming OpenVox then

Ok, it should work like this now

We render snapshots, so that can be used. It's a fairly heavy process though

There isn't something like Rspec to render templates with variables and check if they contain/do not contain what's expected?

[d1nuc0m]

Thanks, I tried to write a test based on your code and existing tests, where could I find some docs for FactoryBot.create? I'd like to add more OSes. Also, is the test part of the suite now or should I add it somewhere?

[ekohl]

We use factory_bot which has its own documentation: https://thoughtbot.github.io/factory_bot/

[ekohl]

Also, in #9516 there's some work to clean up the factories and make them more extensible..

[d1nuc0m]

Thanks, I am implementing Debian/Ubuntu tests and just discovered it doesn't work

[d1nuc0m]

@ekohl done, to add OSes like Ubuntu 24.04, it should be added to test/factories/operatingsystem.rb before? And, is it enough to place the voxpupuli repo test file in test/unit/foreman/templates/snippets or I should declare it somewhere?

[ekohl]

I think this is starting to look very good.

[ekohl]

I'd like to prevent the case where both Vox and Puppet repos are enabled so perhaps this can be:

• if openvox_enabled → snippet('voxpupuli_repo')
• else if puppet_enabled → snippet('puppetlabs_repo')
• if openvox_enabled or puppet_enabled →snippet('puppet_setup')

That probably needs some redefinition of puppet_enabled

[d1nuc0m]

Ok, I'll try after Fosdem/CfgMgmtCamp