Skip to content

Fixes #39050 - PostgreSQL process name pattern is wrong in PCP foreman-hotproc config file#10815

Merged
evgeni merged 1 commit intotheforeman:developfrom
pablomh:patch-1
Feb 2, 2026
Merged

Fixes #39050 - PostgreSQL process name pattern is wrong in PCP foreman-hotproc config file#10815
evgeni merged 1 commit intotheforeman:developfrom
pablomh:patch-1

Conversation

@pablomh
Copy link
Contributor

@pablomh pablomh commented Jan 9, 2026

To match current reality:

[root@satellite ~]# ps auxw | grep -w -e postgres -e postmaster
postgres  139026  0.1  0.3 4429260 112736 ?      Ss   Jan08   1:49 /usr/bin/postmaster -D /var/lib/pgsql/data
postgres  139027  0.0  0.0  91644 20752 ?        Ss   Jan08   0:00 postgres: logger 
postgres  139029  0.0  7.7 4430672 2531748 ?     Ss   Jan08   0:36 postgres: checkpointer 
postgres  139030  0.0  0.2 4429648 81124 ?       Ss   Jan08   0:04 postgres: background writer 
postgres  139031  0.0  0.0 4429260 21700 ?       Ss   Jan08   0:15 postgres: walwriter 
postgres  139032  0.0  0.0 4430632 7704 ?        Ss   Jan08   0:02 postgres: autovacuum launcher 
postgres  139033  0.1  0.0  69516  6172 ?        Ss   Jan08   1:21 postgres: stats collector 
postgres  139034  0.0  0.0 4430336 6388 ?        Ss   Jan08   0:00 postgres: logical replication launcher 
postgres  140719  0.0  0.4 4436176 153476 ?      Ss   Jan08   0:15 postgres: pulp pulpcore ::1(56720) idle
postgres  140735  0.0  0.4 4434076 148580 ?      Ss   Jan08   0:16 postgres: pulp pulpcore ::1(56722) idle
. . .

Fixes: https://issues.redhat.com/browse/SAT-41438

@pablomh pablomh changed the title Fix PostgreSQL process name patterns in config PCP: Fix PostgreSQL process name patterns in foreman-hotproc config Jan 9, 2026
@stejskalleos stejskalleos requested a review from evgeni January 27, 2026 12:35
@pablomh pablomh force-pushed the patch-1 branch 2 times, most recently from 82fe681 to 1de067b Compare January 31, 2026 21:32
fname == "redis-server" ||
(fname == "postgres" && psargs ~ /-D/) ||
(fname == "postmaster" && psargs ~ /-D/) ||
psargs ~ /postgres/ ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
psargs ~ /postgres/ ||

Please drop that one :)

@evgeni
Copy link
Member

evgeni commented Feb 2, 2026

Is there a redmine we could reference in the commit message? the bot won't let us merge without :)

@pablomh
Copy link
Contributor Author

pablomh commented Feb 2, 2026

I've just created https://projects.theforeman.org/issues/39050 .

@evgeni
Copy link
Member

evgeni commented Feb 2, 2026

Okay, if you now amend your commit message to read Fixes #39050 - Fix PostgreSQL process name in PCP hotproc config (or something similar, the Fixes #... - part is important), the bot will recognize it correctly and accept the change.

(sorry, commit rules are strict in here)

@pablomh pablomh force-pushed the patch-1 branch 2 times, most recently from b502917 to c36701a Compare February 2, 2026 13:49
@pablomh
Copy link
Contributor Author

pablomh commented Feb 2, 2026

Is the Redmine check failing because of the maybe longer than expected description?

@evgeni
Copy link
Member

evgeni commented Feb 2, 2026

No, Fixes #... - needs to be the first line (the subject)

…n-hotproc config file

Fix PostgreSQL process name patterns in config to match current reality:

```
[root@satellite ~]# ps auxw | grep -w -e postgres -e postmaster
postgres  139026  0.1  0.3 4429260 112736 ?      Ss   Jan08   1:49 /usr/bin/postmaster -D /var/lib/pgsql/data
postgres  139027  0.0  0.0  91644 20752 ?        Ss   Jan08   0:00 postgres: logger
postgres  139029  0.0  7.7 4430672 2531748 ?     Ss   Jan08   0:36 postgres: checkpointer
postgres  139030  0.0  0.2 4429648 81124 ?       Ss   Jan08   0:04 postgres: background writer
postgres  139031  0.0  0.0 4429260 21700 ?       Ss   Jan08   0:15 postgres: walwriter
postgres  139032  0.0  0.0 4430632 7704 ?        Ss   Jan08   0:02 postgres: autovacuum launcher
postgres  139033  0.1  0.0  69516  6172 ?        Ss   Jan08   1:21 postgres: stats collector
postgres  139034  0.0  0.0 4430336 6388 ?        Ss   Jan08   0:00 postgres: logical replication launcher
postgres  140719  0.0  0.4 4436176 153476 ?      Ss   Jan08   0:15 postgres: pulp pulpcore ::1(56720) idle
postgres  140735  0.0  0.4 4434076 148580 ?      Ss   Jan08   0:16 postgres: pulp pulpcore ::1(56722) idle
. . .
```
@pablomh pablomh changed the title PCP: Fix PostgreSQL process name patterns in foreman-hotproc config Fixes #39050 - PostgreSQL process name pattern is wrong in PCP foreman-hotproc config file Feb 2, 2026
@pablomh
Copy link
Contributor Author

pablomh commented Feb 2, 2026

Thanks!!! I get it now :)

@evgeni evgeni merged commit 05ddd86 into theforeman:develop Feb 2, 2026
23 checks passed
@pablomh pablomh deleted the patch-1 branch February 2, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants