Raise supported PHP version to 8.0 and related updates#25
Open
reedy wants to merge 1 commit intothecodedrift:mainfrom
Open
Raise supported PHP version to 8.0 and related updates#25reedy wants to merge 1 commit intothecodedrift:mainfrom
reedy wants to merge 1 commit intothecodedrift:mainfrom
Conversation
Collaborator
Author
|
Basically zero functional changes... Does help not having to worry about testing on ancient PHP versions... Still supported (by this library): 8.1 - 31 Dec 2025 8.0 - 26 Nov 2023 Dropped: 7.4 - 28 Nov 2022 7.3 - 6 Dec 2021 7.2 - 30 Nov 2020 https://www.php.net/supported-versions.php 8.2 is out of active support (31 Dec 2024), and security support drops on 31 Dec 2026 8.3 is also out of active support (31 Dec 2025), but security support has a bit longer left (31 Dec 2027) |
| * @return HOTPResult[] | ||
| */ | ||
| public static function generateByTimeWindow(string $key, int $window, int $min = -1, int $max = 1, $timestamp = false): array | ||
| public static function generateByTimeWindow(string $key, int $window, int $min = -1, int $max = 1, int|false $timestamp = false): array |
Owner
There was a problem hiding this comment.
Quick check. Would this typing change also result in older versions no longer being able to run the library (and would we bump major to do this)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19