fix: Fix django-mongoengine support - #974
Open
last-partizan wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #974 +/- ##
==========================================
- Coverage 98.62% 98.61% -0.02%
==========================================
Files 68 68
Lines 8245 8245
==========================================
- Hits 8132 8131 -1
- Misses 113 114 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tfranzel Hi, this refactors one particular bugfix: 21068e0
I put this code into _map_model_field, becouse that fix has broken my previous fix: overriding _map_model_field to support django-mongoengine field types (MongoEngine/django-mongoengine@2ef9529).
This way it should work fine for both cases.
Refs #200