Skip to content

fix: Fix django-mongoengine support - #974

Open
last-partizan wants to merge 1 commit into
tfranzel:masterfrom
last-partizan:fix-django-mongoengine-support
Open

fix: Fix django-mongoengine support#974
last-partizan wants to merge 1 commit into
tfranzel:masterfrom
last-partizan:fix-django-mongoengine-support

Conversation

@last-partizan

Copy link
Copy Markdown

@tfranzel Hi, this refactors one particular bugfix: 21068e0

I put this code into _map_model_field, becouse that fix has broken my previous fix: overriding _map_model_field to support django-mongoengine field types (MongoEngine/django-mongoengine@2ef9529).

This way it should work fine for both cases.

Refs #200

@codecov

codecov Bot commented Apr 12, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.61%. Comparing base (4387fed) to head (f585c11).
⚠️ Report is 328 commits behind head on master.

Files with missing lines Patch % Lines
drf_spectacular/openapi.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #974      +/-   ##
==========================================
- Coverage   98.62%   98.61%   -0.02%     
==========================================
  Files          68       68              
  Lines        8245     8245              
==========================================
- Hits         8132     8131       -1     
- Misses        113      114       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant