add django rest framework mongoengine support - #181
Conversation
|
thanks for the PR. that is awesome! couple of things before i can really review it.
|
|
I will consider your terms. When the code is completed, I will notify you. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 97.60% 96.84% -0.77%
==========================================
Files 49 50 +1
Lines 3672 3703 +31
==========================================
+ Hits 3584 3586 +2
- Misses 88 117 +29 ☔ View full report in Codecov by Sentry. |
tfranzel
left a comment
There was a problem hiding this comment.
@ngocngoan thanks! that looks so much better!
in order to merge this, we need to test the functionality. here is the test script i created when you first opened the issue, in order to check if this is even remotely working:
https://gist.github.com/tfranzel/c11382ea8e3801b701de0f4ef73fe0d5
feel free to adapt. basic functionality should be included.
| djangorestframework-camel-case>=1.1.2 | ||
| django-filter>=2.3.0 No newline at end of file | ||
| django-filter>=2.3.0 | ||
| pymongo>=3.11.0 |
There was a problem hiding this comment.
pymongo is not required as it is a dependency of mongoengine
mongomock will likely also come in handy for testing
MongoEngineAutoSchema, which inherits from classAutoSchemaand is specified at the entryDEFAULT_SCHEMA_CLASSin the configurationget_mongoengine_extended_doc_excludesthat compatible withmongoengine, specify this function in the config