chore: migrate away from kcd-scripts#711
Open
TrevorBurnham wants to merge 1 commit intotesting-library:mainfrom
Open
chore: migrate away from kcd-scripts#711TrevorBurnham wants to merge 1 commit intotesting-library:mainfrom
TrevorBurnham wants to merge 1 commit intotesting-library:mainfrom
Conversation
TrevorBurnham
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #696
What:
This CR implements a testing and linting configuration for this project that replaces kcd-scripts.
The only intended difference in behavior is that the tests no longer run as part of the precommit hook. Due to the bug described at #696, the
--findRelatedTestsapproach used in kcd-scripts for running the minimal set of tests isn't viable.All non-config code diffs are autofixes from running the linter and formatter.
Why:
Per kentcdodds/kcd-scripts#245 (comment), @kentcdodds recommends migrating away from kcd-scripts. It's not actively maintained and has known bugs.
How:
I used Claude Sonnet 4.5 to assist. The LLM was instructed to set up a configuration with minimal changes relative to kcd-scripts. I did update some dev dependencies (most notably eslint and typescript-eslint) due to peer dependency conflicts between kcd-scripts' versions of those dependencies and the project's existing TypeScript version.
I've confirmed that all tests pass and that the pre-commit hook works as intended.
Checklist: