Skip to content

Revert default wait strategy hook#1346

Merged
cristianrgreco merged 1 commit into
mainfrom
codex/revert-default-wait-strategy
May 27, 2026
Merged

Revert default wait strategy hook#1346
cristianrgreco merged 1 commit into
mainfrom
codex/revert-default-wait-strategy

Conversation

@cristianrgreco
Copy link
Copy Markdown
Collaborator

Summary

  • Reverts Add default wait strategy hook #1340 and removes the default wait strategy hook that is no longer needed for the MockServer update.
  • Restores the wait strategy selector fallback to Wait.forListeningPorts().
  • Removes the associated docs and selector unit test for the reverted hook.

Verification

  • npm run format
  • npm run lint
  • npm run check-compiles
  • npm test -- packages/testcontainers/src/wait-strategies/utils/wait-strategy-selector.test.ts

Test results

All verification commands passed locally.

Semver impact

Patch. This restores the behavior from before #1340. The latest published release marked by GitHub is v12.0.0, published on 2026-05-19, before #1340 merged on 2026-05-27, so this does not remove an API from the latest published release.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 27, 2026

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 4a68659
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/6a16d8e1b95ea40008b04b60
😎 Deploy Preview https://deploy-preview-1346--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco added maintenance Improvements that do not change functionality patch Backward compatible bug fix labels May 27, 2026 — with ChatGPT Codex Connector
@cristianrgreco cristianrgreco merged commit 1077fd6 into main May 27, 2026
263 checks passed
@cristianrgreco cristianrgreco deleted the codex/revert-default-wait-strategy branch May 27, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improvements that do not change functionality patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant