Skip to content

SW-8282 Port web-components CI workflow to Buildkite#761

Merged
constanzauanini merged 8 commits into
mainfrom
constanza/SW-8282
Jun 1, 2026
Merged

SW-8282 Port web-components CI workflow to Buildkite#761
constanzauanini merged 8 commits into
mainfrom
constanza/SW-8282

Conversation

@constanzauanini
Copy link
Copy Markdown
Contributor

No description provided.

@constanzauanini constanzauanini requested a review from a team as a code owner May 8, 2026 21:00
@vercel
Copy link
Copy Markdown

vercel Bot commented May 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web-components Ready Ready Preview, Comment Jun 1, 2026 1:35pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

To increment version on merge, please add one of patch (default), minor, or major label to this PR.

@github-actions github-actions Bot added the patch label May 8, 2026
Copy link
Copy Markdown
Contributor

I think we should probably add release-notes post to this too! It will be helpful in the long run.

@ice1080
Copy link
Copy Markdown
Contributor

ice1080 commented May 12, 2026

I think we should probably add release-notes post to this too! It will be helpful in the long run.

@tommylau523 @constanzauanini does this mean that every time a PR is merged in this repo it generates a slack message and transitions Jira tasks, since every PR creates a new tag?

Copy link
Copy Markdown
Contributor

tommylau523 commented May 12, 2026

I think we should probably add release-notes post to this too! It will be helpful in the long run.

@tommylau523 @constanzauanini does this mean that every time a PR is merged in this repo it generates a slack message and transitions Jira tasks, since every PR creates a new tag?

​I guess so. Perhaps we can update it to not for Patch, but for Minor/Major package updates only, if it gets overbearing. But I don't think we make too many changes to our web-components repo and each package push to npm is technically a release.

@ice1080
Copy link
Copy Markdown
Contributor

ice1080 commented May 12, 2026

​I guess so. Perhaps we can update it to not for Patch, but for Minor/Major package updates only, if it gets overbearing. But I don't think we make too many changes to our web-components repo and each package push to npm is technically a release.

I think I might request that this is done in a separate PR, just to separate concerns. I feel like this repo doesn't need an unreleased.log file, it probably doesn't need Jira transitions, etc

Copy link
Copy Markdown
Contributor

@ice1080 ice1080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a publish-rc.yaml equivalent in buildkite if we're doing our other publishing in buildkite?

Comment thread .buildkite/scripts/version-bump.sh
@constanzauanini
Copy link
Copy Markdown
Contributor Author

​I guess so. Perhaps we can update it to not for Patch, but for Minor/Major package updates only, if it gets overbearing. But I don't think we make too many changes to our web-components repo and each package push to npm is technically a release.

I think I might request that this is done in a separate PR, just to separate concerns. I feel like this repo doesn't need an unreleased.log file, it probably doesn't need Jira transitions, etc

We didn't have unreleased log, release-notes and jira transitions before. I can remove all that for now and make this PR include just the migration to buildkite. If we want any of those new scripts later, we can open new PRs.

@constanzauanini
Copy link
Copy Markdown
Contributor Author

Do we need a publish-rc.yaml equivalent in buildkite if we're doing our other publishing in buildkite?

I didn't do it because publish-rc fires on a "publish rc" PR comment and Buildkite has no native PR-comment trigger. So I left just that in github actions

Copy link
Copy Markdown
Contributor

Do we need a publish-rc.yaml equivalent in buildkite if we're doing our other publishing in buildkite?

I didn't do it because publish-rc fires on a "publish rc" PR comment and Buildkite has no native PR-comment trigger. So I left just that in github actions

​If we want to consolidate our build enviornment on Buildkite only, we can likely setup a webhook trigger on Buildkite for the publish-rc pipeline, and setup GitHub Actions to purely fire a webhook.

The pro is to have the same build enviornment as the rest of the pipeline. The con is that we will have to manage two pipelines for one action in that case.

Copy link
Copy Markdown
Contributor

@ice1080 ice1080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one open question, but approving for now to unblock

Comment thread .buildkite/scripts/deploy-docs.sh
@constanzauanini constanzauanini merged commit 5790cf5 into main Jun 1, 2026
3 checks passed
@constanzauanini constanzauanini deleted the constanza/SW-8282 branch June 1, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants